From: Eryu Guan <eguan@redhat.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] shared/005,7: add check whether debugfs succeeds to set a negative i_size or not
Date: Mon, 20 Feb 2017 10:36:46 +0800 [thread overview]
Message-ID: <20170220023646.GG24562@eguan.usersys.redhat.com> (raw)
In-Reply-To: <58AA50DA.8080409@cn.fujitsu.com>
On Mon, Feb 20, 2017 at 10:13:46AM +0800, Xiao Yang wrote:
> Hi Eryu
>
> Sorry, The previous patch is defective. Please see the following two points:
>
> 1) If the kernel bug has been fixed, stat command fails to get i_size and
> reports "Structure needs cleaning".
>
> 2) shared/007 passed unexpectedly because of invalid argument when debugfs
> fails to set i_size to the highest multiple of 512 below -1. So we need
> to add strict check.
Thanks for the update! I've pushed your patch to upstream yesterday (not
sure why I didn't see the announce email in the list.. I'll resend
shortly, but the upstream repo should have been updated). Please send a
fix based on new master.
Thanks,
Eryu
next prev parent reply other threads:[~2017-02-20 2:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 11:21 [PATCH] shared/005,7: add check whether debugfs succeeds to set a negative i_size or not Xiao Yang
2017-02-20 2:13 ` Xiao Yang
2017-02-20 2:36 ` Eryu Guan [this message]
2017-02-20 5:02 ` [PATCH] shared/005,7: fix making sure debugfs sets negative i_size && add strict check for dd Xiao Yang
2017-02-22 4:20 ` Eryu Guan
2017-02-22 4:56 ` Xiao Yang
2017-02-22 6:53 ` Eryu Guan
2017-02-22 8:17 ` [PATCH v2] shared/005,7: fix making sure debugfs sets negative i_size Xiao Yang
2017-02-20 9:37 ` [PATCH] xfs/133,4: make sure xfs_db sets negative i_size && add strict check for dd Xiao Yang
2017-02-22 9:31 ` [PATCH v2] xfs/133,4: make sure xfs_db sets negative i_size Xiao Yang
2017-02-22 10:49 ` Eryu Guan
2017-02-23 3:23 ` Xiao Yang
2017-02-23 3:35 ` [PATCH v3] " Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220023646.GG24562@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox