From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp1040.oracle.com ([156.151.31.81]:28399 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbdBXXKD (ORCPT ); Fri, 24 Feb 2017 18:10:03 -0500 Date: Fri, 24 Feb 2017 15:09:23 -0800 From: "Darrick J. Wong" Subject: Re: [PATCH] xfs/348: don't run a fuzzer in the auto group Message-ID: <20170224230923.GD22332@birch.djwong.org> References: <20170223075333.GB22332@birch.djwong.org> <20170223111444.GD24562@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170223111444.GD24562@eguan.usersys.redhat.com> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: fstests List-ID: On Thu, Feb 23, 2017 at 07:14:44PM +0800, Eryu Guan wrote: > On Wed, Feb 22, 2017 at 11:53:33PM -0800, Darrick J. Wong wrote: > > xfs/348 can cause the kernel to crash by blowing the i_rwsem assert in > > xfs_destroy_inode on the corrupted inode. Since this is a fuzzer test > > anyway (it calls xfs_db to break the scratch fs), move it to the fuzzers > > group. > > I agreed fuzzers group should be added, but I'm not sure about removing > auto group. I think this is a good & targeted regression test that > excrises the code path that patch "xfs: sanity check directory inode > di_size" fixed. > > And further more, IMO shared/005,7 and xfs/133,4 belong to auto (and > quick) group too, they're all targeted regression test cases. > > If you're worried about crashing kernel by running these tests in auto > group, perhaps we can consider adding them to dangerous group, then run > check with "./check -g auto -x dangerous". But these bugs are all fixed, > the tests shouldn't bring any trouble if running on newer kernels :) Fair enough. :) I'll send a modified patch adding it to fuzzers. --D > > Thanks, > Eryu > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html