From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] [xfstests-bld] test-appliance: yet another file permissions fix
Date: Wed, 1 Mar 2017 14:42:50 -0500 [thread overview]
Message-ID: <20170301194250.33cas2a42hlskol4@thunk.org> (raw)
In-Reply-To: <20170228204643.37016-1-ebiggers3@gmail.com>
On Tue, Feb 28, 2017 at 12:46:43PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Several directories in the kvm-xfstests appliance were still not being
> given the correct file permissions, since they were rsync'ed directly
> into the mounted root filesystem with the '-a' option. Unfortunately it
> seems we can't express "go+u-w" with rsync options (it's not accepted by
> --chmod), but we can copy the files through 'tar' instead, similar to
> what is done elsewhere.
>
> (I didn't notice this earlier because it is kvm-xfstests specific, and
> it only broke a couple tests such as generic/128.)
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2017-03-01 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 20:46 [PATCH] [xfstests-bld] test-appliance: yet another file permissions fix Eric Biggers
2017-03-01 19:42 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301194250.33cas2a42hlskol4@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox