Re: [PATCH] xfstests: test orphan inode recovery on RO mount

[Eryu Guan <eguan@redhat.com>]

On Fri, Mar 10, 2017 at 08:20:36AM -0600, Eric Sandeen wrote:
> On 3/9/17 10:36 PM, Eryu Guan wrote:
> > On Thu, Mar 09, 2017 at 03:31:43PM -0600, Eric Sandeen wrote:
> >> There's a bug in xfs where the orphan inode list
> >> is not processed on a readonly mount, and is still not
> >> processed even if it gets mounted rw.  This test exercises
> >> that, and makes sure that the unlinked list is empty after
> >> a transition to rw and an unmount.
> >>
> >> While we're at it, sanity check the same thing for pure ro
> >> and rw unmounts.
> >>
> >> Now that shutdown is generic, we can test other filesystems
> >> as well, so this is in the generic group.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> 
> ...
> 
> > Do we really need 10s? That seems a bit long to me, and I tested with
> > sleep 3, it also reproduced on XFS (4.11-rc1).
> > 
> > Otherwise look good to me. I can fix them all at commit time if you're
> > OK with "sleep 3".
> 
> Sure, thanks.  The 10s came from another test w/ the same setup.
> Happy to resend too, if you'd prefer.

No worries, I've fixed them up and gone through release testing.

Thanks,
Eryu