Re: [PATCH v2] overlay/030: test immutable and append-only upper files

[Eryu Guan <eguan@redhat.com>]

On Wed, Apr 05, 2017 at 03:09:27PM +0300, Amir Goldstein wrote:
> Run the t_immutable test program for immutable/append-only files
> and directories in an overlayfs upper directory.
> 
> This test is similar and was derived from generic/079, but
> the original test is _notrun on overlay mount because FS_IOC_GETFLAGS
> FS_IOC_SETFLAGS ioctls fail on overlay directory inodes.
> 
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
>  tests/generic/079     |  6 ++---
>  tests/overlay/030     | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/overlay/030.out |  5 ++++
>  tests/overlay/group   |  1 +
>  4 files changed, 81 insertions(+), 4 deletions(-)
>  create mode 100755 tests/overlay/030
>  create mode 100644 tests/overlay/030.out
> 
> Eryu,
> 
> Here is v2 with fixes to your comments.
> 
> I also changed generic/079 to use modern _require_* statements.
> and removed _scratch_unmount from its cleanup callback.

Thanks! But it'd be better to have two patches, one for new case and one
for 079 cleanup.

Thanks,
Eryu