From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH 3/3] android-xfstests: move ROOT_FS and ROOT_FS_URL into config.android
Date: Mon, 17 Apr 2017 14:33:27 -0700 [thread overview]
Message-ID: <20170417213327.36520-3-ebiggers3@gmail.com> (raw)
In-Reply-To: <20170417213327.36520-1-ebiggers3@gmail.com>
From: Eric Biggers <ebiggers@google.com>
This allows them to be overridden by ~/.config/android-xfstests. Also
start treating an empty ROOT_FS_URL as meaning that no URL is provided.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
Documentation/android-xfstests.md | 3 ++-
kvm-xfstests/android-xfstests | 9 +++------
kvm-xfstests/config.android | 6 ++++++
3 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/Documentation/android-xfstests.md b/Documentation/android-xfstests.md
index b309c21..5b37f9e 100644
--- a/Documentation/android-xfstests.md
+++ b/Documentation/android-xfstests.md
@@ -39,7 +39,8 @@ devices. If you encounter a problem, please submit a fix!
[building-xfstests](building-xfstests.md). Then, either put the
chroot tarball in the default location of
kvm-xfstests/test-appliance/armhf_root_fs.tar.gz, or specify it with
- the -I option to android-xfstests.
+ ROOT_FS in your ~/.config/android-xfstests or the -I option to
+ android-xfstests.
## Procedure
diff --git a/kvm-xfstests/android-xfstests b/kvm-xfstests/android-xfstests
index 3489bc2..e33955e 100755
--- a/kvm-xfstests/android-xfstests
+++ b/kvm-xfstests/android-xfstests
@@ -10,12 +10,6 @@ fi
. "$DIR/util/get-config"
-# Path to chroot tarball; can be overridden with -I
-ROOT_FS="$DIR/test-appliance/armhf_root_fs.tar.gz"
-
-# Where to download the tarball from (at user's request) if we don't have it
-ROOT_FS_URL="https://www.kernel.org/pub/linux/kernel/people/tytso/kvm-xfstests/armhf_root_fs.tar.gz"
-
# Chroot directory on device.
# Note: this will be wiped clean when deploying a new chroot tarball.
CHROOT_DIR="/data/xfstests-chroot"
@@ -142,6 +136,9 @@ setup_chroot()
if ! [ -f "$ROOT_FS" ]; then
echo "The xfstests chroot tarball does not exist:"
echo " $ROOT_FS"
+ if [ -z "$ROOT_FS_URL" ]; then
+ exit 1
+ fi
ask_yesno "Would you like to download the latest public tarball to that location?"
wget -O "$ROOT_FS" "$ROOT_FS_URL"
echo "Finished downloading chroot tarball."
diff --git a/kvm-xfstests/config.android b/kvm-xfstests/config.android
index 4b668f8..ed7098c 100644
--- a/kvm-xfstests/config.android
+++ b/kvm-xfstests/config.android
@@ -4,3 +4,9 @@
# Variables set here may be overridden in ~/.config/android-xfstests
#
+# Path to chroot tarball; this can also be set by the -I option
+ROOT_FS="$DIR/test-appliance/armhf_root_fs.tar.gz"
+
+# Where to download the tarball from (at user's request) if we don't have it.
+# If you want to disable this functionality, set this to an empty string.
+ROOT_FS_URL="https://www.kernel.org/pub/linux/kernel/people/tytso/kvm-xfstests/armhf_root_fs.tar.gz"
--
2.12.2.762.g0e3151a226-goog
next prev parent reply other threads:[~2017-04-17 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 21:33 [PATCH 1/3] xfstests-bld: use a separate default config file for each test runner Eric Biggers
2017-04-17 21:33 ` [PATCH 2/3] gce-xfstests: move NR_CPU, MEM, and ROOT_FS into config.gce Eric Biggers
2017-04-17 21:33 ` Eric Biggers [this message]
2017-04-21 5:57 ` [PATCH 3/3] android-xfstests: move ROOT_FS and ROOT_FS_URL into config.android Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417213327.36520-3-ebiggers3@gmail.com \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox