Re: [PATCH v2 2/3] DAX-DIO: skip DAX to non-DAX if unsupported

Jeff Moyer
2017-04-11T13:54:26Z

Eryu Guan <eguan@redhat.com> writes:

> On Mon, Apr 10, 2017 at 02:05:52PM +0800, Xiong Zhou wrote:
>> By tweaking SCRATCH_DEV by ndctl, only run DAX mapped
>> area DIO to non-DAX area tests when pmem device is in
>> "memory mode".
>>
>> Signed-off-by: Xiong Zhou <xzhou@redhat.com>

> I'm not sure if it's proper to change the pmem device mode in tests.
> IMO, fstests just takes use of user specified TEST|SCRATCH_DEV and
> checks if they meet our requirements.
>
> So I think the correct way is just check the mode of pmem device and
> _notrun if the mode isn't compatible with this test.

It's a scratch device, so I see no issue with changing the mode. If you
don't allow this, then we'll need to run through the tests several times
with different configurations just to get full coverage.

-Jeff