From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34909 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932161AbdD0SQf (ORCPT ); Thu, 27 Apr 2017 14:16:35 -0400 Received: by mail-pf0-f194.google.com with SMTP id a188so12645096pfa.2 for ; Thu, 27 Apr 2017 11:16:35 -0700 (PDT) Date: Thu, 27 Apr 2017 11:16:32 -0700 From: Eric Biggers Subject: Re: [PATCH] android-xfstests: allow detection of SELinux Message-ID: <20170427181632.GA11396@gmail.com> References: <20170311005306.129624-1-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170311005306.129624-1-ebiggers3@gmail.com> Sender: fstests-owner@vger.kernel.org To: Theodore Ts'o Cc: fstests@vger.kernel.org, Eric Biggers List-ID: On Fri, Mar 10, 2017 at 04:53:06PM -0800, Eric Biggers wrote: > From: Eric Biggers > > xfstests is supposed to disable the creation of SELinux xattrs because > this interferes with some tests (e.g. generic/062 and generic/377), but > this was not working on Android. For the android-xfstests portion of > the fix, make the following changes: > > 1. To stop the mount program from stripping the 'context' mount option, > mount selinuxfs and create an empty /etc/selinux/config. This makes the > is_selinux_enabled() function from libselinux return true. > > 2. To stop xfstests from thinking that SELinux is disabled, link > /usr/sbin/selinuxenabled to /bin/true. (Note: getting the real version > of selinuxenabled by adding selinux-utils to the chroot tarball would > also work, though no other programs from it are needed yet, and some > don't work in the chroot environment yet.) > > In combination with the xfstests patch to stop hard-coding SELinux > contexts in xfstests, this fixes the failing tests. > > Signed-off-by: Eric Biggers Ted, this patch seems to have gotten lost; can you apply it? The corresponding xfstests-dev fix has already been merged. Thanks! - Eric