From: Liu Bo <bo.li.liu@oracle.com>
To: Filipe Manana <fdmanana@gmail.com>
Cc: fstests@vger.kernel.org,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] fstests: regression test for btrfs buffered read's repair
Date: Fri, 28 Apr 2017 11:29:38 -0700 [thread overview]
Message-ID: <20170428182937.GA8398@lim.localdomain> (raw)
In-Reply-To: <CAL3q7H7Q6BuOLYTi5AD529x+N02-z5B6MuRxLuUvRVPNDE1Obw@mail.gmail.com>
On Fri, Apr 28, 2017 at 10:52:12AM +0100, Filipe Manana wrote:
> On Wed, Apr 26, 2017 at 7:09 PM, Liu Bo <bo.li.liu@oracle.com> wrote:
> > This case tests whether buffered read can repair the bad copy if we
> > have a good copy.
> >
> > Commit 20a7db8ab3f2 ("btrfs: add dummy callback for readpage_io_failed
> > and drop checks") introduced the regression.
> >
> > The upstream fix is
> > Btrfs: bring back repair during read
>
> Same issue as reported for the other new test (btrfs/140), the test
> fails on a kernel with the mentioned patch. Seems like it does wrong
> assumptions somewhere (I haven't investigated, just run the test):
Thanks for running the test, what I've missed is that chunk start offset depends
on disk size, so I'll add a filesystem size limit to mkfs.
Thanks,
-liubo
prev parent reply other threads:[~2017-04-28 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 18:09 [PATCH v2] fstests: regression test for btrfs buffered read's repair Liu Bo
2017-04-28 9:52 ` Filipe Manana
2017-04-28 18:29 ` Liu Bo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428182937.GA8398@lim.localdomain \
--to=bo.li.liu@oracle.com \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox