From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH] test-appliance: limit checkpointing to gce-xfstests only
Date: Mon, 1 May 2017 10:04:32 -0700 [thread overview]
Message-ID: <20170501170432.94512-1-ebiggers3@gmail.com> (raw)
From: Eric Biggers <ebiggers@google.com>
Results checkpointing by filesystem config, as introduced by
f3c85210f147 ("test-appliance: checkpoint fs configurations that are
completed") only really makes sense for gce-xfstests, which uses a new
results directory per GCE instance. It doesn't make sense for
kvm-xfstests and android-xfstests because the same results directory may
be reused for many different test runs, with different kernels and/or
different sets of tests. Therefore, for now limit the checkpointing to
gce-xfstests only.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
kvm-xfstests/test-appliance/files/root/runtests.sh | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/kvm-xfstests/test-appliance/files/root/runtests.sh b/kvm-xfstests/test-appliance/files/root/runtests.sh
index ec676a9..6544e1c 100755
--- a/kvm-xfstests/test-appliance/files/root/runtests.sh
+++ b/kvm-xfstests/test-appliance/files/root/runtests.sh
@@ -304,7 +304,8 @@ do
XFS_IO_AVOID="${XFS_IO_AVOID/# /}"
fi
echo $FS/$i > /run/fstest-config
- if grep -q "^$FS/$i\$" "$RESULTS/fstest-completed"
+ if test -n "$RUN_ON_GCE" && \
+ grep -q "^$FS/$i\$" "$RESULTS/fstest-completed"
then
echo "$FS/$i: already run"
/usr/local/lib/gce-logger already run
@@ -440,7 +441,9 @@ END { if (NR > 0) {
gce_run_hooks fs-config-end $i
umount "$TEST_DIR" >& /dev/null
umount "$SCRATCH_MNT" >& /dev/null
- cat /run/fstest-config >> "$RESULTS/fstest-completed"
+ if test -n "$RUN_ON_GCE" ; then
+ cat /run/fstest-config >> "$RESULTS/fstest-completed"
+ fi
echo -n "END TEST: $TESTNAME " ; date
logger "END TEST $i: $TESTNAME "
done
--
2.13.0.rc0.306.g87b477812d-goog
next reply other threads:[~2017-05-01 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 17:04 Eric Biggers [this message]
2017-05-02 4:42 ` [PATCH] test-appliance: limit checkpointing to gce-xfstests only Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501170432.94512-1-ebiggers3@gmail.com \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox