public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: "Yan, Zheng" <ukernel@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: attr: add support for cephfs
Date: Thu, 4 May 2017 15:57:02 +0800	[thread overview]
Message-ID: <20170504075702.GL7250@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAAM7YA=rCf_y1r8+SwWL9rpjEnFrfBg5Y6oQMqokXuH7-PPHsw@mail.gmail.com>

[cc'ed fstests list]

On Thu, May 04, 2017 at 03:49:27PM +0800, Yan, Zheng wrote:
> On Thu, May 4, 2017 at 1:00 PM, Eryu Guan <eguan@redhat.com> wrote:
> > On Thu, May 04, 2017 at 11:44:46AM +0800, Yan, Zheng wrote:
> >> On Thu, May 4, 2017 at 11:23 AM, Eryu Guan <eguan@redhat.com> wrote:
> >> > On Wed, May 03, 2017 at 11:54:13AM +0100, Luis Henriques wrote:
> >> >> Block size for cephfs is 4M, which makes generic/020 test fail as the
> >> >> value for MAX_ATTRS and MAX_ATTRVAL_SIZE will be too high.  Restrict these
> >> >> two variables to sane values for this FSTYP.
> >> >>
> >> >> Signed-off-by: Luis Henriques <lhenriques@suse.com>
> >> >
> >> > Thanks for the patch! I'd like some reviews from ceph developers on the
> >> > ceph MAX_ATTRS and MAX_ATTRVAL_SIZE numbers.
> >> >
> >>
> >> Currently we don't have any limitation on single xattr size and number
> >> of xattrs. But single xattr size is limited to 65536 by kernel.
> >
> > Thanks! Can I take it as a Reviewed-by tag?
> 
> 
> yes

Thanks!

Eryu

  parent reply	other threads:[~2017-05-04  7:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 10:54 [PATCH] fstests: attr: add support for cephfs Luis Henriques
2017-05-04  3:23 ` Eryu Guan
2017-05-04  3:44   ` Yan, Zheng
2017-05-04  5:00     ` Eryu Guan
     [not found]       ` <CAAM7YA=rCf_y1r8+SwWL9rpjEnFrfBg5Y6oQMqokXuH7-PPHsw@mail.gmail.com>
2017-05-04  7:57         ` Eryu Guan [this message]
2017-05-04  9:29     ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504075702.GL7250@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=ukernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox