From: Luis Henriques <lhenriques@suse.com>
To: fstests@vger.kernel.org
Cc: "Yan, Zheng" <ukernel@gmail.com>, Luis Henriques <lhenriques@suse.com>
Subject: [PATCH] src/seek_sanity_test: ensure file size is big enough
Date: Fri, 5 May 2017 15:57:23 +0100 [thread overview]
Message-ID: <20170505145723.13582-1-lhenriques@suse.com> (raw)
Tests test07, test08, and test09 preallocate a file and assume the file
size used is bigger than 10xbufsz (100xbufsz for test09). This patch
adjusts the file size so this assumption is always true.
As an example, here's test06 output for cephfs, where the allocation size
is set to 4194304, and the output is (4194304 * 10 + 4194304)
07. Test file with unwritten extents, only have dirty pages
07.01 SEEK_HOLE expected 0 or 4194304, got 46137344. FAIL
07.02 SEEK_HOLE expected 1 or 4194304, got 46137344. FAIL
(Note: The test will be skipped if an integer overflow occurs.)
Signed-off-by: Luis Henriques <lhenriques@suse.com>
---
src/seek_sanity_test.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
index a6dd48cc257b..41da59801212 100644
--- a/src/seek_sanity_test.c
+++ b/src/seek_sanity_test.c
@@ -282,6 +282,13 @@ static int test09(int fd, int testnum)
int bufsz = alloc_size;
int filsz = 8 << 20;
+ while ((filsz < (bufsz * 100 + bufsz)) && (filsz > 0))
+ filsz <<= 1;
+ if (filsz <= 0) {
+ fprintf(stdout, "Test skipped due to int overflow.\n");
+ return ret;
+ }
+
/*
* HOLE - unwritten DATA in dirty page - HOLE -
* unwritten DATA in writeback page
@@ -338,6 +345,13 @@ static int test08(int fd, int testnum)
int bufsz = alloc_size;
int filsz = 4 << 20;
+ while ((filsz < (bufsz * 10 + bufsz)) && (filsz > 0))
+ filsz <<= 1;
+ if (filsz <= 0) {
+ fprintf(stdout, "Test skipped due to int overflow.\n");
+ return ret;
+ }
+
/* HOLE - unwritten DATA in writeback page */
/* Each unit is bufsz */
buf = do_malloc(bufsz);
@@ -387,6 +401,13 @@ static int test07(int fd, int testnum)
int bufsz = alloc_size;
int filsz = 4 << 20;
+ while ((filsz < (bufsz * 10 + bufsz)) && (filsz > 0))
+ filsz <<= 1;
+ if (filsz <= 0) {
+ fprintf(stdout, "Test skipped due to int overflow.\n");
+ return ret;
+ }
+
/* HOLE - unwritten DATA in dirty page */
/* Each unit is bufsz */
buf = do_malloc(bufsz);
next reply other threads:[~2017-05-05 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 14:57 Luis Henriques [this message]
2017-05-08 8:52 ` [PATCH] src/seek_sanity_test: ensure file size is big enough Eryu Guan
2017-05-08 9:37 ` Luis Henriques
2017-05-08 9:45 ` Luis Henriques
2017-05-08 10:47 ` Eryu Guan
2017-05-08 15:12 ` [PATCH v2] " Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505145723.13582-1-lhenriques@suse.com \
--to=lhenriques@suse.com \
--cc=fstests@vger.kernel.org \
--cc=ukernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox