Re: [PATCH] generic/285: Add more SEEK_HOLE tests

Jan Kara
2017-05-12T08:12:44Z

On Fri 12-05-17 16:04:43, Eryu Guan wrote:
> On Thu, May 11, 2017 at 06:48:09PM +0200, Jan Kara wrote:
> > Add tests for bugs found in ext4 & xfs SEEK_HOLE implementations
> > fixed by following patches:
> >
> > xfs: Fix missed holes in SEEK_HOLE implementation
> > ext4: Fix SEEK_HOLE
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> This will cause ext4 and xfs start to fail with current linus tree and
> appear as a new regression. So we usually don't add new tests to
> existing cases.
>
> But seek_sanity_test.c deals with different SEEK_DATA/HOLE implentations
> nicely, which would be a bit tricky to do in a new test by shell, and it
> has all the infrastructures for new tests like this. So I think I'd
> prefer merging this patch as is, and document the false regression alert
> in release announce email.

Yeah, I agree regressing a test is not ideal but at least from the full
output it would be visible that the new testcases are those that failed and
at that point it is same as if a new test was failing.

> I'm including this patch in release testing now, please shout if ext4
> and/or xfs developers have different thoughts, there'll be around two
> days before new release :)

Thanks!

Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR