From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com ([209.132.183.28]:44748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800AbdEPH6s (ORCPT ); Tue, 16 May 2017 03:58:48 -0400 From: Eryu Guan Subject: [PATCH] build: workaround build failures with old autoconf version Date: Tue, 16 May 2017 15:58:32 +0800 Message-Id: <20170516075832.4612-1-eguan@redhat.com> Sender: fstests-owner@vger.kernel.org To: fstests@vger.kernel.org Cc: yangx.jy@cn.fujitsu.com, gwendal@chromium.org, Eryu Guan List-ID: Xiao Yang reported that fstests failed to build on RHEL6.9 hosts due to old autoreconf didn't pass -I to aclocal -I. This was fixed by autoconf commit 44fbeef86d03 ("Pass autoreconf -I to aclocal -I"). So call aclocal, autoheader and autoconf directly instead of autoreconf, as what's done in xfsprogs Makefile. Also add include/config.h.in to CONFIGURE, which is generated by autoheader, so it also gets removed by make realclean. Reported-by: Xiao Yang Signed-off-by: Eryu Guan --- Hi Xiao Yang, can you please this patch on your RHEL6 host? It works for me. Hi Gwendal, can you please test if cross-compilation still works for chromeOS? I don't have the chromeOS environment to test.. Thanks! Makefile | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index ebf5c03..dd8d344 100644 --- a/Makefile +++ b/Makefile @@ -41,7 +41,7 @@ endif SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz -CONFIGURE = configure include/builddefs include/config.h \ +CONFIGURE = configure include/builddefs include/config.h include/config.h.in \ aclocal.m4 config.guess config.sub install-sh ltmain.sh \ m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \ m4/lt~obsolete.m4 @@ -79,8 +79,10 @@ clean: # if configure hasn't run, nothing to clean endif configure: configure.ac - autoreconf --include=m4 - libtoolize -i + libtoolize -cfi + aclocal -I m4 + autoheader + autoconf include/builddefs include/config.h: configure ./configure \ -- 2.9.3