From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36776 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdEPWob (ORCPT ); Tue, 16 May 2017 18:44:31 -0400 Date: Tue, 16 May 2017 15:44:28 -0700 From: Eric Biggers Subject: Re: [PATCH] generic: test that encrypted filenames are presented without collisions Message-ID: <20170516224428.GE113464@gmail.com> References: <20170502001524.114018-1-ebiggers3@gmail.com> <20170504073008.GK7250@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170504073008.GK7250@eguan.usersys.redhat.com> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: fstests@vger.kernel.org, Eric Biggers , linux-fscrypt@vger.kernel.org List-ID: On Thu, May 04, 2017 at 03:30:08PM +0800, Eryu Guan wrote: > On Mon, May 01, 2017 at 05:15:24PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > [RFC for now since the kernel fixes are currently sitting in fscrypt/master and > > haven't been merged to Linus's tree yet; I'll resend this once they're merged] > > > > Add a test which creates many similarly-named files in an encrypted > > directory, then verifies they can be deleted without access to the > > encryption key. This is a regression test for two related bugs which > > caused presented names to "collide" and point to the wrong inodes. > > > > Cc: linux-fscrypt@vger.kernel.org > > Signed-off-by: Eric Biggers > > The test looks fine to me, it fails on ext4 with rm reporting "Structure > needs cleaning". > > One minor issue is that rm reports too many failures (around 98000 > lines in my test) > > +rm: cannot remove '/mnt/testarea/scratch/edir/_SET,lbqVCybotHoHkKrq4xM7FtbuBCLY': Structure needs cleaning > > and that makes the output diff a bit harder to review, and takes too > much space in 500.out.bad file unnecessarily (11M). Better to trim or > limit the error log somehow, e.g. using "head -n 10"? > > Thanks, > Eryu Yes, I'll limit it to 10 error messages. Thanks! Eric