From: Eryu Guan <eguan@redhat.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] Drop _require_fssum
Date: Mon, 22 May 2017 22:47:49 +0800 [thread overview]
Message-ID: <20170522144749.GU7250@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170522010528.23463-2-tytso@mit.edu>
On Sun, May 21, 2017 at 09:05:28PM -0400, Theodore Ts'o wrote:
> Now that fssum is built unconditionally, we no longer need
> _require_fssum.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> common/rc | 6 ------
> tests/btrfs/007 | 1 -
> tests/btrfs/016 | 1 -
> tests/btrfs/030 | 1 -
> tests/btrfs/038 | 1 -
> tests/btrfs/039 | 1 -
> tests/btrfs/040 | 1 -
> tests/btrfs/043 | 1 -
> tests/btrfs/044 | 1 -
> tests/btrfs/045 | 1 -
> tests/btrfs/046 | 1 -
> tests/btrfs/050 | 1 -
> tests/btrfs/051 | 1 -
> tests/btrfs/053 | 1 -
> tests/btrfs/077 | 1 -
> tests/btrfs/083 | 1 -
> tests/btrfs/084 | 1 -
> tests/btrfs/087 | 1 -
> tests/btrfs/092 | 1 -
> tests/btrfs/127 | 1 -
> tests/btrfs/128 | 1 -
> tests/btrfs/129 | 1 -
> tests/btrfs/133 | 1 -
> tests/btrfs/134 | 1 -
> tests/btrfs/135 | 1 -
> 25 files changed, 30 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index 65886886..796f60e7 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3164,12 +3164,6 @@ _require_ugid_map()
> fi
> }
>
> -_require_fssum()
> -{
> - FSSUM_PROG=$here/src/fssum
> - [ -x $FSSUM_PROG ] || _notrun "fssum not built"
> -}
> -
I think this is still needed. It has FSSUM_PROG definition (otherwise
all these btrfs tests failed due to unable to find $FSSUM_PROG), and we
do check for existence of binary files in src, even the file is built
unconditionally on make. They can be removed accidently or one may
forget to build a newly added test.
Thanks,
Eryu
next prev parent reply other threads:[~2017-05-22 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 1:05 [PATCH 1/2] Stop relying on OpenSSL Theodore Ts'o
2017-05-22 1:05 ` [PATCH 2/2] Drop _require_fssum Theodore Ts'o
2017-05-22 14:47 ` Eryu Guan [this message]
2017-05-22 15:35 ` Theodore Ts'o
2017-05-25 17:41 ` [PATCH] Stop relying on OpenSSL Theodore Ts'o
2017-05-22 14:38 ` [PATCH 1/2] " Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522144749.GU7250@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox