From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH] test-appliance: revert logging change on startup
Date: Tue, 23 May 2017 21:17:08 -0700 [thread overview]
Message-ID: <20170524041708.16580-1-ebiggers3@gmail.com> (raw)
From: Eric Biggers <ebiggers@google.com>
Commit 458ce3391003 ("Add support to optionally build gce-xfstests for
Debian stretch") made the output of kvm-xfstests.boot get redirected to
a file /var/log/kvm-xfstests-boot.log. This actually isn't desirable,
because the output is supposed to be shown on the console. This was
especially apparent for kvm-xfstests, since it hid the output of
runtests.sh. But it was also applicable to gce-xfstests, since
'gce-xfstests console' can be used to show the console output.
We could send the output to both places using 'tee', but this seems
useless since the output can just be retrieved from the console instead
of from the log file. Also, the 'set -vx' output is too verbose for the
console, and I don't think there would be a way to send it just to the
log file.
So just revert the change to kvm-xfstests.boot.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot | 7 -------
1 file changed, 7 deletions(-)
diff --git a/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot b/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
index 4b687d0..26ef2fd 100755
--- a/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
+++ b/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
@@ -11,13 +11,6 @@ else
fi
}
-date >> /var/log/kvm-xfstests-boot.log
-exec 1<&-
-exec 2<&-
-exec 1>> /var/log/kvm-xfstests-boot.log
-exec 2>&1
-set -vx
-
. /root/test-config
FSTESTCFG=$(parse fstestcfg | sed -e 's/,/ /g')
--
2.13.0
reply other threads:[~2017-05-24 4:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524041708.16580-1-ebiggers3@gmail.com \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox