From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap.thunk.org ([74.207.234.97]:38296 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942950AbdEYRYO (ORCPT ); Thu, 25 May 2017 13:24:14 -0400 Date: Thu, 25 May 2017 13:24:11 -0400 From: "Theodore Ts'o" Subject: Re: [PATCH v2] kvm-xfstests, gce-xfstests: improve recommended kernel config Message-ID: <20170525172411.tbi56oe27oz6rnuj@thunk.org> References: <20170523174557.60810-1-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170523174557.60810-1-ebiggers3@gmail.com> Sender: fstests-owner@vger.kernel.org To: Eric Biggers Cc: fstests@vger.kernel.org, Amir Goldstein , Eric Biggers List-ID: On Tue, May 23, 2017 at 10:45:57AM -0700, Eric Biggers wrote: > From: Eric Biggers > > Trim more unneeded features from the recommended kernel config, then > enable some more relatively lightweight debugging options. > > For now, just update the latest x86_64 config. But if people are okay > with these changes I'll update some of the other configs too. > > Tested with both kvm-xfstests and gce-xfstests. > > Signed-off-by: Eric Biggers This looks good to me. Would you mind sending a patch which updates the rest of the configs similarly, so we can update all of the configs at once? As an aside, I *do* use the HW_RANDOM_VIRTIO from time to time (that's why it was enabled in the config), and in fact kvm-xfstests is wired up to supply the virtio random number generator by default (since it doesn't really cost much): if test -z "$NO_VIRTIO_RNG" ; then VIRTIO_RNG="-object rng-random,filename=/dev/urandom,id=rng0 \ -device virtio-rng-pci,rng=rng0" fi But that's for my kernel RNG testing, and it's fair to say that that most users of kvm-xfstests won't need it. Thanks, - Ted