From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Omar Sandoval <osandov@osandov.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH] generic: test Btrfs delalloc accounting overflow
Date: Fri, 2 Jun 2017 14:46:52 +0200 [thread overview]
Message-ID: <20170602124652.GJ12135@twin.jikos.cz> (raw)
In-Reply-To: <9f328b7d-5d07-a72f-72b1-bf334fd80a02@suse.com>
On Fri, Jun 02, 2017 at 12:07:37PM +0300, Nikolay Borisov wrote:
> > +# Make sure that we didn't leak any metadata space.
> > +if [[ $FSTYP = btrfs ]]; then
> > + uuid="$(findmnt -n -o UUID "$TEST_DIR")"
>
> if we are on btrfs and we don't have findmnt this test will likely fail.
> Perhaps include a _require_command findmnt
I think utilities like findmnt should be checked at the beginning of the
whole testuiste, not in each test that uses them. As findmnt is part of
util-linux, missing it would also mean that eg 'mount' is missing.
Highly unlikely.
next prev parent reply other threads:[~2017-06-02 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 8:23 [PATCH] generic: test Btrfs delalloc accounting overflow Omar Sandoval
2017-06-02 9:07 ` Nikolay Borisov
2017-06-02 12:46 ` David Sterba [this message]
2017-06-03 7:01 ` Eryu Guan
2017-06-03 7:37 ` Christoph Hellwig
2017-06-07 0:03 ` Omar Sandoval
2017-06-07 3:08 ` Eryu Guan
2017-06-07 3:12 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602124652.GJ12135@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox