From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33615 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbdGFCyb (ORCPT ); Wed, 5 Jul 2017 22:54:31 -0400 Received: by mail-pf0-f193.google.com with SMTP id e199so1088872pfh.0 for ; Wed, 05 Jul 2017 19:54:30 -0700 (PDT) Date: Wed, 5 Jul 2017 19:54:28 -0700 From: Eric Biggers Subject: Re: [PATCH] generic/247: unmount test device, not scratch device Message-ID: <20170706025428.GA595@zzz.localdomain> References: <20170705203754.92140-1-ebiggers3@gmail.com> <20170706025059.GW23360@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170706025059.GW23360@eguan.usersys.redhat.com> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: fstests@vger.kernel.org, Brian Foster , Eric Biggers List-ID: On Thu, Jul 06, 2017 at 10:50:59AM +0800, Eryu Guan wrote: > On Wed, Jul 05, 2017 at 01:37:54PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > Commit d55123c080cb ("generic/247: filter out expected XFS warnings for > > mixed mmap/direct I/O") made generic/247 start explicitly unmounting the > > scratch device. However, the test doesn't actually use the scratch > > device, so it will fail if SCRATCH_DEV is undefined. Fix it by > > unmounting the test device instead. > > > > Signed-off-by: Eric Biggers > > Thanks for the fix! I found this in my review and I remembered I removed > the _scratch_unmount and updated the comments accordingly at commit > time, but clearly I didn't. > It was removed from generic/095 (maybe by accident?) but not generic/247. Perhaps it needs to be added back to generic/095? Eric