public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: fstests@vger.kernel.org, Brian Foster <bfoster@redhat.com>,
	Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2] generic/095, generic/247: unmount correct devices
Date: Thu, 6 Jul 2017 13:35:24 +0800	[thread overview]
Message-ID: <20170706053524.GA29475@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170706053136.6825-1-ebiggers3@gmail.com>

On Wed, Jul 05, 2017 at 10:31:36PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> In commit d55123c080cb ("generic/247: filter out expected XFS warnings
> for mixed mmap/direct I/O"), _scratch_unmount was removed from
> generic/095 and added to generic/247.  But actually generic/095 *should*
> be unmounting SCRATCH_DEV; and generic/247 should be unmounting
> TEST_DEV, not SCRATCH_DEV, since it doesn't use a scratch device (it was
> failing if SCRATCH_DEV was not defined).  Fix it.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks a lot!

Eryu

      reply	other threads:[~2017-07-06  5:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06  5:31 [PATCH v2] generic/095, generic/247: unmount correct devices Eric Biggers
2017-07-06  5:35 ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706053524.GA29475@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=bfoster@redhat.com \
    --cc=ebiggers3@gmail.com \
    --cc=ebiggers@google.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox