From: Eryu Guan <eguan@redhat.com>
To: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
Cc: fstests@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [xfstests PATCH v4] generic: add test of file mode when setfacl fails
Date: Wed, 19 Jul 2017 14:45:53 +0800 [thread overview]
Message-ID: <20170719064553.GA2478@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170719055146.GA7249@debian.home>
On Wed, Jul 19, 2017 at 02:51:50AM -0300, Ernesto A. Fernández wrote:
> Check that the group permission bits of a file are not altered when setfacl
> fails. At the time of this patch the test fails for at least ext2, ext4,
> jfs and btrfs.
>
> The failure in setfacl is induced by filling the device and setting as
> many user attributes to the file as possible. For xfs this is not enough,
> and the test will not run.
>
> Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
> ---
> Changes in v4:
> - Continue to set attributes even when the filesystem claims to be out of
> space. With this change the test will now fail for btrfs.
> - Call _notrun when setfacl succeeds, since no check can be done. As suggested
> by Eryu Guan.
Thanks a lot for the update! I've queued it for next fstests update.
Eryu
prev parent reply other threads:[~2017-07-19 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 5:51 [xfstests PATCH v4] generic: add test of file mode when setfacl fails Ernesto A. Fernández
2017-07-19 6:45 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719064553.GA2478@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox