Re: [RFC PATCH] check: try to fix the test device if it gets corrupted

Theodore Ts'o
2017-03-04T00:36:32Z

On Fri, Mar 03, 2017 at 09:21:57AM -0800, Darrick J. Wong wrote:
>
> <shrug> The test device isn't supposed to get corrupted, since it (at
> least in theory) should be an old filesystem. That said, I suppose
> there's little point in banging around with a corrupt test fs. Maybe we
> could go further and stop running if there's unfixable corruption?

Yes, that was the other alternative I considered. In my case, though,
since I'm trying to get a sense of how many failures I have to deal
with, I really wanted a "make -k" behavior that would continue after
the first failure. After all, all I was going to do was manually run
fsck, and then continue the run --- so we might as well have the check
script do it automatically and then allow things to continue.

We could make it be configurable, via a command-line option. The -k
option isn't taken so we could have check -k that works like make -k
if you think that's better. OTOH, perhaps making -k the default
behaviour is actually the better way to go, and in that case, maybe
it's not worth having the command-line flag?

- Ted