From: Eric Biggers <ebiggers3@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2 13/15] common: remove IRIX-specific code
Date: Fri, 28 Jul 2017 09:50:19 -0700 [thread overview]
Message-ID: <20170728165019.GA144538@gmail.com> (raw)
In-Reply-To: <20170728111926.GE9167@eguan.usersys.redhat.com>
On Fri, Jul 28, 2017 at 07:19:26PM +0800, Eryu Guan wrote:
> > -#
> > -# Filtering of Irix character hwgraph device names
> > -# e.g.
> > -# chardev: /hw/node/xtalk/15/pci/0/scsi_ctlr/0/target/1/lun/0/disk/partition/4/char
> > -# blkdev: /dev/dsk/dks0d1s4
> > -#
> > -_filter_devchar()
> > -{
> > - $AWK_PROG '
> > - /\/hw\/node/ {
> > - sub(/\/hw.*scsi_ctlr\//,"/dev/dsk/dks") # blah blah /dev/dsk/dks0/target/1/....
> > - sub(/\/target\//,"d") # blah blah /dev/dsk/dks0d1/lun/0/disk.....
> > - sub(/\/lun.*partition\//,"s") # blah blah /dev/dsk/dks0d1s4/char
> > - sub(/\/char/,"") # blah blah /dev/dsk/dks0d1s4
> > - }
> > - { print }
> > - '
> > -}
> > -
> >
> > #
> > # Filter out the non-deterministic dump msgs from
> > @@ -824,7 +803,6 @@ _filter_devchar()
> > #
> > _dump_filter_main()
> > {
> > - _filter_devchar |\
>
> I added this _filter_devchar function back as xfs/061 needs it,
> otherwise it fails like:
>
> -xfsrestore: volume: /dev/dsk/dks0d2s1
> +xfsrestore: volume: /hw/node/io/gio/hpc/scsi_ctlr/0/target/2/lun/0/disk/partition/1/char
>
> I think this is the safest and easiest thing to do at this moment.
>
Okay, that's fine for now. Thanks for testing!
Eric
next prev parent reply other threads:[~2017-07-28 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 4:38 [PATCH v2 00/15] xfstests: remove IRIX support Eric Biggers
2017-07-21 4:38 ` [PATCH v2 01/15] tests: port generic/093 to Linux Eric Biggers
2017-07-21 4:38 ` [PATCH v2 02/15] tests: port generic/097 " Eric Biggers
2017-07-21 4:38 ` [PATCH v2 03/15] tests: port xfs/095 " Eric Biggers
2017-07-21 4:38 ` [PATCH v2 04/15] tests: remove udf/098 Eric Biggers
2017-07-21 4:38 ` [PATCH v2 05/15] tests: remove udf/101 Eric Biggers
2017-07-21 4:38 ` [PATCH v2 06/15] tests: remove xfs/114 and xfs/115 Eric Biggers
2017-07-21 4:38 ` [PATCH v2 07/15] tests: remove xfs/057 and xfs/058 Eric Biggers
2017-07-21 4:38 ` [PATCH v2 08/15] tests: remove generic/099 Eric Biggers
2017-07-21 4:38 ` [PATCH v2 09/15] tests: make shared/051 a generic test Eric Biggers
2017-07-21 4:38 ` [PATCH v2 10/15] README: remove IRIX-specific documentation Eric Biggers
2017-07-21 4:38 ` [PATCH v2 11/15] tests: remove IRIX support from tests also supported on Linux Eric Biggers
2017-07-21 4:38 ` [PATCH v2 12/15] tests: clean up per-OS output files Eric Biggers
2017-07-21 4:38 ` [PATCH v2 13/15] common: remove IRIX-specific code Eric Biggers
2017-07-28 11:19 ` Eryu Guan
2017-07-28 16:50 ` Eric Biggers [this message]
2017-07-21 4:38 ` [PATCH v2 14/15] build: remove IRIX-specific build logic Eric Biggers
2017-07-21 4:38 ` [PATCH v2 15/15] include: remove some unused headers Eric Biggers
2017-07-24 4:43 ` [PATCH v2 00/15] xfstests: remove IRIX support Eryu Guan
2017-07-24 17:38 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728165019.GA144538@gmail.com \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).