From: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org,
"Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
Subject: Re: [PATCH v2] generic/449: make the test effective against xfs
Date: Wed, 2 Aug 2017 12:48:09 -0300 [thread overview]
Message-ID: <20170802154808.GA1239@debian.home> (raw)
In-Reply-To: <20170802070030.GT9167@eguan.usersys.redhat.com>
On Wed, Aug 02, 2017 at 03:00:30PM +0800, Eryu Guan wrote:
> On Wed, Aug 02, 2017 at 01:19:34AM -0300, Ernesto A. Fernández wrote:
> >
> > +# The content of this file will be used as the value of the attributes
> > +VFILE=$SCRATCH_MNT/valuefile
> > +touch $VFILE
> > +$XFS_IO_PROG -c "pwrite -S 0x2E 0 1k" $VFILE >>$seqres.full 2>&1
> > +
>
> I think this VFILE is not needed, because ..
>
> > # Try to run out of space so setfacl will fail
> > $XFS_IO_PROG -c "pwrite 0 50m" $TFILE >>$seqres.full 2>&1
> > i=1
> > +while $SETFATTR_PROG -n trusted.$i -v $(cat $VFILE) $TFILE &>/dev/null; do
>
> we can use something like $(perl -e 'print "a"x1024') to generate 1k
> attr value.
All right.
> I can fix it at commit time if this looks OK to you.
That's great, thanks.
next prev parent reply other threads:[~2017-08-02 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 4:55 [PATCH] generic/449: make the test effective against xfs Ernesto A. Fernández
2017-08-02 1:33 ` Eryu Guan
2017-08-02 4:12 ` Ernesto A. Fernández
2017-08-02 4:19 ` [PATCH v2] " Ernesto A. Fernández
2017-08-02 7:00 ` Eryu Guan
2017-08-02 15:48 ` Ernesto A. Fernández [this message]
2017-08-02 17:33 ` Darrick J. Wong
2017-08-02 20:59 ` Ernesto A. Fernández
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802154808.GA1239@debian.home \
--to=ernesto.mnd.fernandez@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox