From: Brian Foster <bfoster@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: batch update of test file mode
Date: Thu, 3 Aug 2017 08:10:37 -0400 [thread overview]
Message-ID: <20170803121036.GG62447@bfoster.bfoster> (raw)
In-Reply-To: <20170803055304.20928-1-eguan@redhat.com>
On Thu, Aug 03, 2017 at 01:53:04PM +0800, Eryu Guan wrote:
> Some tests don't have x permission set in mode, git complains about
> file mode change after running tests in fstests git repo dir. So
> change all such tests to 755 mode. Performed by:
>
> find tests ! -perm /111 -name [0-9][0-9][0-9] -exec chmod 755 {} \;
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
>
> We've done this several times before, now I've written a local
> post-applypatch hook that will detect & change the wrong test file
> permissions and prompt to do 'git commit --amend'. Hope that this is the
> last commit to do such changes..
>
Reviewed-by: Brian Foster <bfoster@redhat.com>
> Eryu
>
> tests/generic/340 | 0
> tests/generic/341 | 0
> tests/generic/342 | 0
> tests/generic/344 | 0
> tests/generic/345 | 0
> tests/generic/346 | 0
> tests/generic/354 | 0
> tests/generic/408 | 0
> 8 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tests/generic/340
> mode change 100644 => 100755 tests/generic/341
> mode change 100644 => 100755 tests/generic/342
> mode change 100644 => 100755 tests/generic/344
> mode change 100644 => 100755 tests/generic/345
> mode change 100644 => 100755 tests/generic/346
> mode change 100644 => 100755 tests/generic/354
> mode change 100644 => 100755 tests/generic/408
>
> diff --git a/tests/generic/340 b/tests/generic/340
> old mode 100644
> new mode 100755
> diff --git a/tests/generic/341 b/tests/generic/341
> old mode 100644
> new mode 100755
> diff --git a/tests/generic/342 b/tests/generic/342
> old mode 100644
> new mode 100755
> diff --git a/tests/generic/344 b/tests/generic/344
> old mode 100644
> new mode 100755
> diff --git a/tests/generic/345 b/tests/generic/345
> old mode 100644
> new mode 100755
> diff --git a/tests/generic/346 b/tests/generic/346
> old mode 100644
> new mode 100755
> diff --git a/tests/generic/354 b/tests/generic/354
> old mode 100644
> new mode 100755
> diff --git a/tests/generic/408 b/tests/generic/408
> old mode 100644
> new mode 100755
> --
> 2.13.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-08-03 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 5:53 [PATCH] fstests: batch update of test file mode Eryu Guan
2017-08-03 12:10 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803121036.GG62447@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox