From: Eryu Guan <eguan@redhat.com>
To: Brian Foster <bfoster@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] fstests: remove tmp files properly
Date: Fri, 4 Aug 2017 14:56:14 +0800 [thread overview]
Message-ID: <20170804065614.GD1991@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170803121030.GF62447@bfoster.bfoster>
On Thu, Aug 03, 2017 at 08:10:31AM -0400, Brian Foster wrote:
> On Thu, Aug 03, 2017 at 12:33:04PM +0800, Eryu Guan wrote:
> > Some tests and common helpers don't properly clean up tmp files and
> > leave them behind in /tmp dir, and these tmp files are accumulating
> > over time.
> >
> > Signed-off-by: Eryu Guan <eguan@redhat.com>
> > ---
> > v2:
> > - fix tmp_dir usage in _mkfs_dev as well
> >
>
> FWIW, there are a couple tests that do 'tmp=$$' instead of 'tmp=/tmp/$$'
> as well. I'm not sure how appropriate that is. That aside:
Ah, they're generic/436 and generic/445 that I didn't notice in review.
Not a big problem but still worth fixing, perhas in another cleanup
patch along with other similar fixes (if there're any).
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
And thanks a lot for all the reviews!
Eryu
next prev parent reply other threads:[~2017-08-04 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 4:33 [PATCH v2] fstests: remove tmp files properly Eryu Guan
2017-08-03 12:10 ` Brian Foster
2017-08-04 6:56 ` Eryu Guan [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-12 4:27 Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804065614.GD1991@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox