From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v4 5/5] fsx: add support for keeping existing file
Date: Thu, 7 Sep 2017 22:06:52 +0800 [thread overview]
Message-ID: <20170907140652.GT8034@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAOQ4uxhFEVc4CCj1eCecVrGYrz4WqH_a0rEdBkTjtnTLd-dUBw@mail.gmail.com>
On Thu, Sep 07, 2017 at 03:38:59PM +0300, Amir Goldstein wrote:
> On Thu, Sep 7, 2017 at 10:26 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> > With fsx -k, do not truncate existing file and use its size as upper
> > bound on file size.
> >
> > This is needed to prevent fsx from truncating the file on start of
> > test when testing fsx on cloned files.
> >
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > ---
>
> > - if (lite) {
> > + if (!(o_flags & O_TRUNC)) {
> > off_t ret;
> > - file_size = maxfilelen = lseek(fd, (off_t)0, SEEK_END);
> > + file_size = maxfilelen = biggest = lseek(fd, (off_t)0, SEEK_END);
> > + prt("file_size is %lu\n", file_size);
>
> Eryu,
>
> Please remove this added debug log before merging.
> It breaks expected output of test generic/127
Sure, thanks for the heads-up.
Eryu
next prev parent reply other threads:[~2017-09-07 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 7:26 [PATCH v4 0/5] fsx additions for crash consistency tests Amir Goldstein
2017-09-07 7:26 ` [PATCH v4 1/5] fsx: add support for integrity check with dm-log-writes target Amir Goldstein
2017-09-07 7:26 ` [PATCH v4 2/5] fsx: add optional logid prefix to log messages Amir Goldstein
2017-09-07 7:26 ` [PATCH v4 3/5] fsx: add support for recording operations to a file Amir Goldstein
2017-09-07 7:26 ` [PATCH v4 4/5] fsx: add support for writing constant instead of random data Amir Goldstein
2017-09-07 7:26 ` [PATCH v4 5/5] fsx: add support for keeping existing file Amir Goldstein
2017-09-07 12:38 ` Amir Goldstein
2017-09-07 14:06 ` Eryu Guan [this message]
2017-09-07 7:58 ` [PATCH v4 0/5] fsx additions for crash consistency tests Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907140652.GT8034@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox