From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com ([209.132.183.28]:36766 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbdIMHQj (ORCPT ); Wed, 13 Sep 2017 03:16:39 -0400 Date: Wed, 13 Sep 2017 15:16:35 +0800 From: Eryu Guan Subject: Re: [PATCH 3/3] ext4: test for inline data + DAX corruption Message-ID: <20170913071635.GB8034@eguan.usersys.redhat.com> References: <20170912044521.22644-1-ross.zwisler@linux.intel.com> <20170912044521.22644-3-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170912044521.22644-3-ross.zwisler@linux.intel.com> Sender: fstests-owner@vger.kernel.org To: Ross Zwisler Cc: fstests@vger.kernel.org, Andrew Morton , linux-kernel@vger.kernel.org, "Darrick J. Wong" , Theodore Ts'o , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org, Andreas Dilger List-ID: On Mon, Sep 11, 2017 at 10:45:21PM -0600, Ross Zwisler wrote: > Add a regression test for the following kernel commit: > > ext4: prevent data corruption with inline data + DAX > > The test passes either if we don't encounter corruption, or if mounting > with DAX + inline data fails. The latter is the way that we prevent this > issue in the kernel. > > Signed-off-by: Ross Zwisler Besides the gitignore entry order issue and call the test program from $here/src/... issue, need another require rule: _require_ext4_mkfs_feature "inline_data" Otherwise this looks fine to me. Thanks, Eryu