Re: [PATCH] generic/441: whitelist gfs2 for full test

Eryu Guan
2017-07-31T08:49:11Z

On Fri, Jul 28, 2017 at 06:48:27AM -0400, Jeff Layton wrote:
> From: Jeff Layton <jlayton@redhat.com>
>
> gfs2 passes the full-scale generic/441 test with the patch that
> converts it to use errseq_t reporting for fsync.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> tests/generic/441 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/441 b/tests/generic/441
> index 075d87723ca1..b98f709cb6eb 100755
> --- a/tests/generic/441
> +++ b/tests/generic/441
> @@ -55,7 +55,7 @@ case $FSTYP in
> btrfs)
> _notrun "btrfs has a specialized test for this"
> ;;
> - ext3|ext4|xfs)
> + ext3|ext4|gfs2|xfs)

gfs2 has no external log device support yet in _scratch_mkfs, so if test
still passes with patched gfs2 in this case, I think we can test gfs2 in
full-scale mode unconditionally? e.g.

ext3|ext4|xfs)
# Do the more thorough test if we have a logdev
_has_logdev && sflag=''
;;
gfs2)
# <comments here>
sflag=''
;;
*)
;;

Thanks,
Eryu