From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.suse.de ([195.135.220.15]:50514 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750710AbdIRHrR (ORCPT ); Mon, 18 Sep 2017 03:47:17 -0400 Date: Mon, 18 Sep 2017 09:47:13 +0200 From: Johannes Thumshirn Subject: Re: [PATCH] xfs: add regression test for DAX mount option usage Message-ID: <20170918074713.5lravsj234d5pbdj@linux-x5ow.site> References: <20170913233438.GY10621@dastard> <20170914004038.GZ10621@dastard> <20170914131638.qxbzeocvrkhjcjcu@linux-x5ow.site> <20170915091845.pmp3wer5lwx2xhjz@linux-x5ow.site> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Sender: fstests-owner@vger.kernel.org Content-Transfer-Encoding: quoted-printable To: Dan Williams Cc: Jan Kara , Eryu Guan , "Darrick J. Wong" , "linux-nvdimm@lists.01.org" , Dave Chinner , fstests@vger.kernel.org, linux-xfs@vger.kernel.org, Christoph Hellwig List-ID: On Fri, Sep 15, 2017 at 10:39:05AM -0700, Dan Williams wrote: > Yes, but what we're worried about in the libnvdimm/nfit_test case is > internals behind sysfs interfaces. But point taken, we can at least > use the presence of certain attributes to gate tests. However, it does > mean we lose the tests for when an attribute is missing due to an > incomplete backport. Of cause, but all we loose is a group of testcases to be run and this can= be an indication of a bad backport as well, so I think this is quite helpful. Byte, Johannes --=20 Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton HRB 21284 (AG N=FCrnberg) Key fingerprint =3D EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850