public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, fstests@vger.kernel.org
Subject: Re: xfs/310: relax extent count check
Date: Tue, 19 Sep 2017 01:39:17 +0200	[thread overview]
Message-ID: <20170918233917.GA29974@lst.de> (raw)
In-Reply-To: <20170918211042.GA6533@magnolia>

On Mon, Sep 18, 2017 at 02:10:42PM -0700, Darrick J. Wong wrote:
> > +# make sure the allocator didn't allocate more than the needed two extents
> >  echo "Check extent count"
> > -xfs_bmap -l -p -v $testdir/file1 | grep '^[[:space:]]*1:' -q && xfs_bmap -l -p -v $testdir/file1
> > +xfs_bmap -l -p -v $testdir/file1 | grep '^[[:space:]]*2:' -q && xfs_bmap -l -p -v $testdir/file1
> 
> I haven't had time to read the getbmap rework over in xfs-land yet, but
> I'm assuming from this diff that the new getbmap no longer merges adjacent
> records?

Yes.

> Also, won't this break the test on old kernels?

No - it just checks we don't have more than two extents instead of
checking we don't have more than one, so it just relaxes the check
a bit.

  reply	other threads:[~2017-09-18 23:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-03 15:51 xfs/310: relax extent count check Christoph Hellwig
2017-09-06  7:34 ` Eryu Guan
2017-09-14  4:09 ` Eryu Guan
2017-09-18 21:10 ` Darrick J. Wong
2017-09-18 23:39   ` Christoph Hellwig [this message]
2017-09-19  2:28 ` Darrick J. Wong
2017-09-19  2:56   ` Eryu Guan
2017-09-19  3:05   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170918233917.GA29974@lst.de \
    --to=hch@lst.de \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox