public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] fstests: btrfs/150 regression test for reading compressed data
Date: Wed, 27 Sep 2017 17:46:44 +0800	[thread overview]
Message-ID: <20170927094644.GO8034@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170927001851.GA22418@localhost.localdomain>

On Tue, Sep 26, 2017 at 05:18:51PM -0700, Liu Bo wrote:
> On Tue, Sep 26, 2017 at 04:37:52PM -0700, Liu Bo wrote:
> > On Tue, Sep 26, 2017 at 05:02:36PM +0800, Eryu Guan wrote:
> > > On Fri, Sep 22, 2017 at 05:21:27PM -0600, Liu Bo wrote:
> > > > We had a bug in btrfs compression code which could end up with a
> > > > kernel panic.
> > > > 
> > > > This is adding a regression test for the bug and I've also sent a
> > > > kernel patch to fix the bug.
> > > > 
> > > > The patch is "Btrfs: fix kernel oops while reading compressed data".
> > > > 
> > > > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
> > > 
> > > Hmm, I can't reproduce the panic with 4.13 kernel, which doesn't have
> > > the fix applied. Can you please help confirm if it panics on your test
> > > environment?
> > >
> > 
> > Yes, it is reproducible on my box, hrm...I'll be running it more times
> > to double check.
> > 
> 
> It worked for me...both v4.13 and v4.14.0-rc2 have the following
> messages[1].
> 
> This requires two config:
> CONFIG_FAULT_INJECTION=y
> CONFIG_FAULT_INJECTION_DEBUG_FS=y
> 
> Could you please check again?

I re-compiled 4.14-rc2 kernel on my test vm with FAIL_MAKE_REQUEST
enabled (which requires FAULT_INJECTION), and I can reproduce the crash
now. It was so weired that previously I did have FAIL_MAKE_REQUEST
enabled and test ran normally without hitting the bug, but now I can hit
the bug quite reliably. Not sure what was happning in my previous test..

Thanks for confirming!

Eryu

  reply	other threads:[~2017-09-27  9:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20 23:52 [PATCH] fstests: btrfs/150 regression test for reading compressed data Liu Bo
2017-09-21  4:39 ` Dave Chinner
2017-09-22 19:33   ` Liu Bo
2017-09-21  7:03 ` Lu Fengqi
2017-09-22 19:28   ` Liu Bo
2017-09-22 23:21 ` [PATCH v2] " Liu Bo
2017-09-24  7:15   ` Lu Fengqi
2017-09-26  9:02   ` Eryu Guan
2017-09-26 23:37     ` Liu Bo
2017-09-27  0:18       ` Liu Bo
2017-09-27  9:46         ` Eryu Guan [this message]
2017-09-27 17:10           ` Liu Bo
2017-09-27 16:35 ` [PATCH v3] " Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170927094644.GO8034@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=bo.li.liu@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox