From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:16642 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbdI1Bvm (ORCPT ); Wed, 27 Sep 2017 21:51:42 -0400 Date: Thu, 28 Sep 2017 11:51:39 +1000 From: Dave Chinner Subject: Re: [PATCH 1/2] generic/461: Test RWF_NOWAIT Message-ID: <20170928015139.GH10621@dastard> References: <20170927191003.10099-1-rgoldwyn@suse.de> <20170927213454.GD3666@dastard> <2292b367-9880-8e03-fe59-84dc1f2b13da@suse.de> <20170927215139.GE3666@dastard> <4be71a29-e84f-5e3d-67f6-6787f45e1b27@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4be71a29-e84f-5e3d-67f6-6787f45e1b27@suse.de> Sender: fstests-owner@vger.kernel.org To: Goldwyn Rodrigues Cc: fstests@vger.kernel.org List-ID: On Wed, Sep 27, 2017 at 05:24:49PM -0500, Goldwyn Rodrigues wrote: > > > On 09/27/2017 04:51 PM, Dave Chinner wrote: > > On Wed, Sep 27, 2017 at 04:39:20PM -0500, Goldwyn Rodrigues wrote: > >> > >> > >> On 09/27/2017 04:34 PM, Dave Chinner wrote: > >>> On Wed, Sep 27, 2017 at 02:10:02PM -0500, Goldwyn Rodrigues wrote: > >>>> From: Goldwyn Rodrigues > >>>> > >>>> Tests the RWF_NOWAIT flag so the I/O returns immediately on > >>>> a new file, without any block allocations. > >>>> > >>>> A new program which includes the pwritev2() call is used. This allows > >>>> passing flags for the I/O to be performed. > >>> > >>> Rather than write a one-off test program for this that effectively > >>> replicates xfs_io pread/pwrite functionality, please add RWF_NOWAIT > >>> flag support to xfs_io. > >>> > >> > >> This one off program is required because xfs_io does not support partial > >> writes. It tries to do that within the loop and does not return the > >> number of bytes written. This is required for test generic/462. > > > > Then please also extend xfs_io to support partial reads and writes > > in the manner you need. > > > > That will break existing tests which rely on nothing but the error > returned in case of partial writes. So trigger necessary partial write behaviour only when the CLI option to use RWF_NOWAIT is present.... Cheers, Dave. -- Dave Chinner david@fromorbit.com