Re: [PATCH v6 2/4] gitignore: sort src/ binaries name

Dave Chinner
2017-09-28T21:46:02Z

On Thu, Sep 28, 2017 at 08:28:32PM +0800, Xiong Zhou wrote:
> On Thu, Sep 28, 2017 at 09:10:08PM +1000, Dave Chinner wrote:
> > On Thu, Sep 28, 2017 at 03:41:38PM +0800, Xiong Zhou wrote:
> > > Signed-off-by: Xiong Zhou <xzhou@redhat.com>
> >
> > Why? you're not fixing any problem here, and it's completely
> > unrelated to fixing the issue the series is about....
>
> Yes. It's not related and a little weird. Because I'm too lazy
> to split them. This is a "by the way" patch.
>
> If you strongly recommend, I could resend these into 2 series:
> one with the fix of fake failures, the other is the write_ro
> case with the name/group fixes.

Yes, please send them in a separate series - patch series are
supposed to contain related patches. i.e. random changes should
not be added to a set of fixes for a specific problem. Thanks!

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com