From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, Eryu Guan <eguan@redhat.com>
Subject: [PATCH] common/xfs: add iomap_dio_complete() to the dmesg filter
Date: Fri, 29 Sep 2017 12:13:27 +0800 [thread overview]
Message-ID: <20170929041327.1346-1-eguan@redhat.com> (raw)
Kernel commit 332391a9935d ("fs: Fix page cache inconsistency when mixing
buffered and AIO DIO") moved the WARN_ON_ONCE() into iomap_dio_complete(),
along with the page cache invalidation. Let's add iomap_dio_complete() to the
filter whitelist too, so this expected warning when mixing direct I/O with
buffered I/O won't fail tests.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
common/xfs | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/xfs b/common/xfs
index def28bfc7309..c869aaca4512 100644
--- a/common/xfs
+++ b/common/xfs
@@ -610,11 +610,13 @@ _filter_xfs_dmesg()
local warn5="WARNING:.*fs/iomap\.c:.*iomap_dio_rw.*"
local warn6="WARNING:.*fs/xfs/xfs_aops\.c:.*__xfs_get_blocks.*"
local warn7="WARNING:.*fs/iomap\.c:.*iomap_dio_actor.*"
+ local warn8="WARNING:.*fs/iomap\.c:.*iomap_dio_complete.*"
sed -e "s#$warn1#Intentional warnings in xfs_file_dio_aio_write#" \
-e "s#$warn2#Intentional warnings in xfs_file_dio_aio_read#" \
-e "s#$warn3#Intentional warnings in xfs_file_read_iter#" \
-e "s#$warn4#Intentional warnings in xfs_file_aio_read#" \
-e "s#$warn5#Intentional warnings in iomap_dio_rw#" \
-e "s#$warn6#Intentional warnings in __xfs_get_blocks#" \
- -e "s#$warn7#Intentional warnings in iomap_dio_actor#"
+ -e "s#$warn7#Intentional warnings in iomap_dio_actor#" \
+ -e "s#$warn8#Intentional warnings in iomap_dio_complete#"
}
--
2.13.6
next reply other threads:[~2017-09-29 4:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 4:13 Eryu Guan [this message]
2017-09-29 4:45 ` [PATCH] common/xfs: add iomap_dio_complete() to the dmesg filter Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929041327.1346-1-eguan@redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox