From: "Theodore Ts'o" <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Ashlie Martinez <ashmrtn@utexas.edu>,
Xiao Yang <yangx.jy@cn.fujitsu.com>, Eryu Guan <eguan@redhat.com>,
Josef Bacik <jbacik@fb.com>, fstests <fstests@vger.kernel.org>,
Ext4 <linux-ext4@vger.kernel.org>,
Vijay Chidambaram <vvijay03@gmail.com>
Subject: Re: [PATCH] ext4: fix interaction between i_size, fallocate, and delalloc after a crash
Date: Sat, 7 Oct 2017 14:32:13 -0400 [thread overview]
Message-ID: <20171007183213.jfezqvcbjslzwm7e@thunk.org> (raw)
In-Reply-To: <CAOQ4uxio+SuAKk35tBh7_rne+YgCsvfS0yoKdipcUsf9noU+eg@mail.gmail.com>
On Sat, Oct 07, 2017 at 08:54:06AM +0300, Amir Goldstein wrote:
> > If fallocate(2) is called with the FALLOC_FL_KEEP_SIZE flag, either
>
> According to patch without keep size flag?
Oops, thanks for catching that. I'll fix the commit description.
> BTW looking at the patch, does truncate racing with fallocate that
> would increase size beyond truncated size works correctly?
Yes, because we the inode is locked via i_mutex (well, now an write
lock on i_rwsem) during both truncate and fallocate operations.
- Ted
next prev parent reply other threads:[~2017-10-07 18:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 10:44 [RFC][PATCH] fstest: regression test for ext4 crash consistency bug Amir Goldstein
2017-09-25 9:49 ` Xiao Yang
2017-09-25 10:53 ` Amir Goldstein
2017-09-26 10:45 ` Xiao Yang
2017-09-26 11:48 ` Amir Goldstein
2017-09-30 14:15 ` Ashlie Martinez
2017-10-05 7:27 ` Xiao Yang
2017-10-05 15:04 ` Ashlie Martinez
2017-10-05 19:10 ` Amir Goldstein
2017-10-06 0:34 ` Ashlie Martinez
2017-10-07 3:29 ` [PATCH] ext4: fix interaction between i_size, fallocate, and delalloc after a crash Theodore Ts'o
2017-10-07 5:54 ` Amir Goldstein
2017-10-07 18:32 ` Theodore Ts'o [this message]
2017-10-09 0:37 ` Ashlie Martinez
2017-10-11 11:11 ` Xiao Yang
2017-10-11 13:17 ` Ashlie Martinez
2017-10-11 13:34 ` Amir Goldstein
2017-10-16 19:32 ` Ashlie Martinez
2017-10-16 21:11 ` Amir Goldstein
2017-10-17 0:09 ` Theodore Ts'o
2017-10-17 1:02 ` Vijay Chidambaram
[not found] ` <CAPaz=E+jFuOmRk8+EmVhNawwogNzW3VkciFrCc0Fk23OfGbwuA@mail.gmail.com>
2017-10-17 7:15 ` Amir Goldstein
2017-10-17 14:41 ` Theodore Ts'o
2017-10-17 23:16 ` Vijay Chidambaram
2017-10-12 14:38 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171007183213.jfezqvcbjslzwm7e@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=ashmrtn@utexas.edu \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jbacik@fb.com \
--cc=linux-ext4@vger.kernel.org \
--cc=vvijay03@gmail.com \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox