public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: fstests@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>
Subject: Re: [PATCH 0/3] generalize AIO/DIO dmesg filter
Date: Thu, 12 Oct 2017 12:25:15 +0800	[thread overview]
Message-ID: <20171012042515.GY10593@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1507647298-9971-1-git-send-email-idryomov@gmail.com>

On Tue, Oct 10, 2017 at 04:54:55PM +0200, Ilya Dryomov wrote:
> With upstream commit 332391a9935d ("fs: Fix page cache inconsistency
> when mixing buffered and AIO DIO"), we need to whitelist dio_complete()
> for ext4 pretty much everywhere iomap_dio_complete() and friends are
> whitelisted for xfs.

Thanks for fixing this! I agreed with Dave that we should move the
filter to common/filter file, but that's easy to do and I can fix it up
at commit time.

I was thinking adding this filter to _check_dmesg unconditionally, so we
don't have to the filter case by case. But I guess it's better to be
more careful, in case we miss any real bug.

Thanks,
Eryu

  parent reply	other threads:[~2017-10-12  4:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 14:54 [PATCH 0/3] generalize AIO/DIO dmesg filter Ilya Dryomov
2017-10-10 14:54 ` [PATCH 1/3] common/rc: move _filter_xfs_dmesg() to common/rc Ilya Dryomov
2017-10-11  5:35   ` Dave Chinner
2017-10-10 14:54 ` [PATCH 2/3] common/rc: turn _filter_xfs_dmesg() into _filter_aiodio_dmesg() Ilya Dryomov
2017-10-10 14:54 ` [PATCH 3/3] generic/036,208: whitelist [iomap_]dio_complete() WARNs Ilya Dryomov
2017-10-12  4:25 ` Eryu Guan [this message]
2017-10-12  7:19   ` [PATCH 0/3] generalize AIO/DIO dmesg filter Ilya Dryomov
2017-10-12  7:25     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012042515.GY10593@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=lczerner@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox