Re: [PATCH] generic/4[13,62]: restore TEST mount options

Dave Chinner
2017-10-30T20:37:01Z

On Mon, Oct 30, 2017 at 10:08:31AM +0200, Omer Zilberberg wrote:
> These tests locally change the TEST_FS_MOUNT_OPTS/MOUNT_OPTIONS
> environment variables, and run _test_cycle_mount. As a result, following
> tests using the TEST mount point may start with different mount options,
> depending on run order.

I don't think that's the case. The change of the environment
variable should only affect the current test process and it's
children. When the test exits, we go back to the environment of the
check process, where the TEST_FS_MOUNT_OPTS environment variable is
still correctly set, and all future tests inherit from that. i.e.:

$ export FOO=foo
$ echo $FOO
foo
$ bash
$ echo $FOO
foo
$ export FOO=bar
$ echo $FOO
bar
$ exit
$ echo $FOO
foo
$

And after each test, check runs _check_filesystems(), which cycles
the test mount, so for each new test process that is run they should
already start in the correct state...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com