Re: [PATCH] generic/252: fix aiocp buffer alignment

Zorro Lang
2017-11-10T06:50:07Z

On Fri, Nov 10, 2017 at 12:54:44PM +0800, Eryu Guan wrote:
> On Thu, Nov 09, 2017 at 04:09:01PM +0800, Zorro Lang wrote:
> > g/252 fails on 4k hard sector size disk, due to aiocp.c use 512
> > bytes alignment by default. So use the '-a' option of aiocp, to
> > specify a proper alignment size.
> >
> > Signed-off-by: Zorro Lang <zlang@redhat.com>
>
> There're other tests that calls aiocp with direct I/O, I think they can
> be fixed too in one patch.
>
> $ grep -H DIRECT `grep aiocp tests/* -rI | cut -d: -f1 | sort | uniq`
> tests/generic/252:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full
> tests/generic/329:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full
> tests/generic/330:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full
> tests/xfs/237:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full
> tests/xfs/239:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full

OK, I'm going to look into them, to see if there's a better way to fix them all.

>
> Thanks,
> Eryu
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html