public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Eryu Guan <eguan@redhat.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] common: rework _require_ext4_mkfs_feature
Date: Tue, 14 Nov 2017 21:57:05 -0500	[thread overview]
Message-ID: <20171115025705.agxu5v4dmm2ja532@thunk.org> (raw)
In-Reply-To: <20171115005655.GE4094@dastard>

On Wed, Nov 15, 2017 at 11:56:55AM +1100, Dave Chinner wrote:
> Implement, like in mkfs.xfs, the "-N" flag (a.k.a "--dry-run").
> It does option parsing and geometry calculations, outputs the config
> that would be made, then exits before doing any actual IO. Hence we
> can check mkfs feature support on XFS, and only take the time to
> make a filesystem if we need to check that kernel support exists.

mke2fs has a -n option, but that's not what I'm trying to address.

Now that we want to *mount* the file system to check to see if the
kernel can support the file system feature, we can no longer use the
-n option.  And since the tests all need to create the file system
*anyway*, it seemed rather pointless to create it once, then do the
trial mount, and then creating the file system a second time.

      	     	      	       	   	       - Ted

      reply	other threads:[~2017-11-15  2:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-12 13:36 [PATCH] common: rework _require_ext4_mkfs_feature Theodore Ts'o
2017-11-14 11:43 ` Eryu Guan
2017-11-14 23:38   ` Theodore Ts'o
2017-11-15  0:30     ` [PATCH -v3] " Theodore Ts'o
2017-11-16  4:00       ` Eryu Guan
2017-11-15  0:56   ` [PATCH] " Dave Chinner
2017-11-15  2:57     ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171115025705.agxu5v4dmm2ja532@thunk.org \
    --to=tytso@mit.edu \
    --cc=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox