From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: fstests <fstests@vger.kernel.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>, Jan Kara <jack@suse.cz>,
Dave Chinner <david@fromorbit.com>,
Dan Williams <dan.j.williams@intel.com>,
Amir Goldstein <amir73il@gmail.com>
Subject: [fstests PATCH v4 2/4] dm-log-writes: only replay log to marks that exist
Date: Fri, 17 Nov 2017 13:28:26 -0700 [thread overview]
Message-ID: <20171117202828.25472-3-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20171117202828.25472-1-ross.zwisler@linux.intel.com>
The 'replay-log' executable will replay the dm-log-writes log until the
given mark, or until the end of the log if the mark isn't found.
This means that if the mark you're looking for was never inserted in the
log or if you give garbage to _log_writes_replay_log() the entire log will
be replayed. This can cause unexpected test results.
Fix this by making sure that the mark we're given actually exists in the
log before we allow the replay.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
common/dmlogwrites | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/common/dmlogwrites b/common/dmlogwrites
index 247c744..80ed4fc 100644
--- a/common/dmlogwrites
+++ b/common/dmlogwrites
@@ -72,6 +72,10 @@ _log_writes_replay_log()
{
_mark=$1
+ $here/src/log-writes/replay-log --log $LOGWRITES_DEV --find \
+ --end-mark $_mark >> $seqres.full 2>&1
+ [ $? -ne 0 ] && _fail "mark does not exist"
+
$here/src/log-writes/replay-log --log $LOGWRITES_DEV --replay $SCRATCH_DEV \
--end-mark $_mark >> $seqres.full 2>&1
[ $? -ne 0 ] && _fail "replay failed"
--
2.9.5
next prev parent reply other threads:[~2017-11-17 20:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 20:28 [fstests PATCH v4 0/4] add test for DAX MAP_SYNC support Ross Zwisler
2017-11-17 20:28 ` [fstests PATCH v4 1/4] common/rc: add _scratch_has_mount_option() Ross Zwisler
2017-11-17 20:28 ` Ross Zwisler [this message]
2017-11-18 3:51 ` [fstests PATCH v4 2/4] dm-log-writes: only replay log to marks that exist Eryu Guan
2017-11-17 20:28 ` [fstests PATCH v4 3/4] dm-log-writes: allow DAX to be used when possible Ross Zwisler
2017-11-18 6:17 ` Eryu Guan
2017-12-05 23:21 ` Ross Zwisler
2017-11-17 20:28 ` [fstests PATCH v4 4/4] generic: add test for DAX MAP_SYNC support Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117202828.25472-3-ross.zwisler@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=amir73il@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox