From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com ([209.132.183.28]:55666 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbdKUHS2 (ORCPT ); Tue, 21 Nov 2017 02:18:28 -0500 Date: Tue, 21 Nov 2017 15:18:26 +0800 From: Eryu Guan Subject: Re: [PATCH 1/2] overlay/038: code cleanup Message-ID: <20171121071826.GN2749@eguan.usersys.redhat.com> References: <20171120143410.23357-1-chandan@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: fstests-owner@vger.kernel.org To: Amir Goldstein Cc: Chandan Rajendra , fstests , overlayfs List-ID: On Tue, Nov 21, 2017 at 08:33:53AM +0200, Amir Goldstein wrote: > On Mon, Nov 20, 2017 at 4:34 PM, Chandan Rajendra > wrote: > > This commit implements similar changes made to overlay/041 test i.e. > > - Remove duplicate merged dir tests > > - Remove duplicate pure upper dir inside merged dir tests > > - Sort out comments and error messages > > > > Signed-off-by: Chandan Rajendra > > Looks good and tested. > > Nit: one trailing whitespace in this patch. > Applying: overlay/038: code cleanup > .git/rebase-apply/patch:114: trailing whitespace. > > warning: 1 line adds whitespace errors. I can fix that up on commit. Thanks for the review! Eryu