FS/XFS testing framework
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Chengguang Xu <cgxu@mykernel.net>
Cc: Amir Goldstein <amir73il@gmail.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] common: Add infrastructure for syncfs syscall tests
Date: Fri, 1 Dec 2017 12:13:01 +0800	[thread overview]
Message-ID: <20171201041301.GB2749@eguan.usersys.redhat.com> (raw)
In-Reply-To: <621FF37E-8612-489C-8721-4BBC08BAB336@mykernel.net>

On Fri, Dec 01, 2017 at 12:04:44PM +0800, Chengguang Xu wrote:
> Hi Eryu,
> 
> Actually, in my another test case generic/470 will need to check whether fs supports syncfs or not. 
> I make shared infrastructure for checking that, and because it is common component 
> I post as an individual patch instead of including in the case of generic/470.

I think "_require_xfs_io_command syncfs" should be fine, there's no need
& not encouraged to add new binary & usage like this. If you want to run
syncfs(2) to make sure the kernel actually supports it, you can add a
new 'syncfs' switch case in _require_xfs_io_command.

Thanks,
Eryu

  reply	other threads:[~2017-12-01  4:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  3:55 [PATCH] common: Add infrastructure for syncfs syscall tests Chengguang Xu
2017-12-01  4:04 ` Chengguang Xu
2017-12-01  4:13   ` Eryu Guan [this message]
2017-12-01  6:38     ` Chengguang Xu
2017-12-01  7:21       ` Amir Goldstein
2017-12-01 21:43         ` Dave Chinner
2017-12-02 10:43           ` Amir Goldstein
2017-12-02 11:37             ` Amir Goldstein
2017-12-02 21:40             ` Dave Chinner
2017-12-03  6:45               ` Amir Goldstein
2017-12-04  6:05                 ` Chengguang Xu
2017-12-04  8:44                   ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201041301.GB2749@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=amir73il@gmail.com \
    --cc=cgxu@mykernel.net \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox