public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eryu Guan <eguan@redhat.com>, Josef Bacik <jbacik@fb.com>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] generic/456: document the fix commit
Date: Sun, 3 Dec 2017 19:28:39 -0500	[thread overview]
Message-ID: <20171204002838.kicldlczz645hwfw@thunk.org> (raw)
In-Reply-To: <1511419423-7905-2-git-send-email-amir73il@gmail.com>

On Thu, Nov 23, 2017 at 08:43:43AM +0200, Amir Goldstein wrote:
> Add a link to Ted's post with more details about the bug
> and the fix.
> 
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

I'm OK with this, so:

Reviewed-by: Theodore Ts'o <tytso@mit.edu>

> It may be better to include a digest of the refered post embedded
> in the test. For now, I just added the link to mailing list archive.
> Maybe Ted can add the digest later.

Eryu can chime in if he links, but in general we haven't included long
discourses describing the bug in xfstests, so I don't think that's
really necessary.

					- Ted

  reply	other threads:[~2017-12-04  0:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23  6:43 [PATCH 1/2] generic/458: document the fix commit Amir Goldstein
2017-11-23  6:43 ` [PATCH 2/2] generic/456: " Amir Goldstein
2017-12-04  0:28   ` Theodore Ts'o [this message]
2017-11-27 16:47 ` [PATCH 1/2] generic/458: " Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204002838.kicldlczz645hwfw@thunk.org \
    --to=tytso@mit.edu \
    --cc=amir73il@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=jbacik@fb.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox