From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com ([209.132.183.28]:29760 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbdLUKWC (ORCPT ); Thu, 21 Dec 2017 05:22:02 -0500 Date: Thu, 21 Dec 2017 18:21:58 +0800 From: Eryu Guan Subject: Re: [PATCH] fstests: Add 9p network filesystem support Message-ID: <20171221102158.GH5123@eguan.usersys.redhat.com> References: <20171212171154.5222-1-tuomas@tuxera.com> <20171218141227.GB5123@eguan.usersys.redhat.com> <1513609136.28209.19.camel@tuxera.com> <1513825990.10114.0.camel@tuxera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513825990.10114.0.camel@tuxera.com> Sender: fstests-owner@vger.kernel.org To: Tuomas Tynkkynen Cc: fstests@vger.kernel.org List-ID: On Thu, Dec 21, 2017 at 05:13:10AM +0200, Tuomas Tynkkynen wrote: > On Mon, 2017-12-18 at 16:58 +0200, Tuomas Tynkkynen wrote: > > Hi Eryu, > > > > On Mon, 2017-12-18 at 22:12 +0800, Eryu Guan wrote: > > > On Tue, Dec 12, 2017 at 07:11:54PM +0200, Tuomas Tynkkynen wrote: > > > > This commit adds support for the 9p network file system, which is > > > > mainly > > > > used by QEMU for sharing a file system from the host to the guest > > > > VM. > > > > > > > > To run xfstests on it, launch QEMU with e.g.: > > > > > > > > -virtfs local,path=$TMPDIR/p9-test,security_model=mapped- > > > > xattr,mount_tag=p9-test > > > > -virtfs local,path=$TMPDIR/p9-scratch,security_model=mapped- > > > > xattr,mount_tag=p9-scratch > > > > > > > > and inside the VM run xfstests with: > > > > > > > > export TEST_DEV=p9-test > > > > export SCRATCH_DEV=p9-scratch > > > > export MOUNT_OPTIONS="-o > > > > trans=virtio,version=9p2000.L,cache=loose,posixacl" > > > > export TEST_FS_MOUNT_OPTS="$MOUNT_OPTIONS" > > > > > > We can take 9P_MOUNT_OPTIONS as the default value for both > > > MOUNT_OPTIONS > > > and TEST_FS_MOUNT_OPTS in common/config, similar to > > > CIFS_MOUNT_OPTIONS > > > etc. > > > > > > > Ok, will add in next version. > > > > Oops; no. Bash doesn't like environment variables starting with Ah, that's right. > numbers. P9_MOUNT_OPTIONS maybe then? Though honestly, I've never used Or PLAN9_MOUNT_OPTIONS? > nor really understood the reason for these foo_MOUNT_OPTIONS... same > for the -nfs etc. command line flags. Make update fs-specific mount options in local.config file more easily when switching filesysm type to test? You don't have to update MOUNT_OPTIONS and TEST_FS_MOUNT_OPTS. The '-nfs'/'-9p' command line flags are used to indicate which filesystem it's testing and set FSTYP variable correctly. Because these filesystems can't be detected from $TEST_DEV automatically like XFS, ext4 etc. Thanks, Eryu