From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Omar Sandoval <osandov@osandov.com>,
fstests@vger.kernel.org, Eryu Guan <eguan@redhat.com>
Subject: Re: ext4 quota tests fail with CONFIG_QFMT_V2=n
Date: Thu, 18 Jan 2018 11:03:21 -0500 [thread overview]
Message-ID: <20180118160321.GA13944@thunk.org> (raw)
In-Reply-To: <20180118122125.pxgqttayxu6msdgl@quack2.suse.cz>
On Thu, Jan 18, 2018 at 01:21:25PM +0100, Jan Kara wrote:
> Omar's problem is actually that he had no quota format enabled so tools
> failed miserably to enable quotas although xfstests thought quota should be
> available. That could be viewed as a bug in _require_quota() macro in xfstests
> but OTOH userspace has no way of knowing which quota formats are available
> - it can only try to enable quota on a particular fs and that either fails
> or not. So implementing proper _require_quota() macro would mean you have
> to do full quota setup for some filesystem, try to enable quotas, and see if
> that fails. Doable but frankly I'm not hugely interested in that for such a
> cornercase...
Yes, I'd much rather fix it in Kconfig. The question I was asing is
really whether we could start deprecating QFMT_V1 by requiring QFMT_V2
and making QFMT_V1 the only optional format, and then changing the
tools to strongly bias the user towards using V2 --- and maybe making
it be impossible to create new QFMT_V1 format quota files at all at
some point.
It will take a while --- years no doubt --- but a journey of ten
thousand miles starts with a single step, as the saying goes.
- Ted
next prev parent reply other threads:[~2018-01-18 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 1:09 ext4 quota tests fail with CONFIG_QFMT_V2=n Omar Sandoval
2018-01-18 1:28 ` Theodore Ts'o
2018-01-18 2:16 ` Omar Sandoval
2018-01-18 4:08 ` Theodore Ts'o
2018-01-18 8:17 ` Omar Sandoval
2018-01-18 12:08 ` Jan Kara
2018-01-18 23:26 ` Dave Chinner
2018-01-18 12:21 ` Jan Kara
2018-01-18 16:03 ` Theodore Ts'o [this message]
2018-01-19 8:46 ` Jan Kara
2018-01-19 17:14 ` Theodore Ts'o
2018-01-24 10:44 ` Jan Kara
2018-01-18 18:07 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118160321.GA13944@thunk.org \
--to=tytso@mit.edu \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox