From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Eryu Guan <eguan@redhat.com>, fstests@vger.kernel.org
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,
dave.jiang@intel.com
Subject: [fstests PATCH v2] generic/347: dm-thin lacks DAX support
Date: Thu, 18 Jan 2018 09:07:37 -0700 [thread overview]
Message-ID: <20180118160737.24708-1-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20180118042343.GQ3102@eguan.usersys.redhat.com>
generic/347 currently fails when run in conjunction with the DAX mount
option:
generic/347 72s ... - output mismatch (see
/root/project/xfstests/results//generic/347.out.bad)
--- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600
+++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17
16:04:33.459348448 -0700
@@ -1,2 +1,3 @@
QA output created by 347
+mount: /mnt/xfstests_scratch: can't read superblock on
/dev/mapper/thin-vol.
=== completed
...
(Run 'diff -u tests/generic/347.out
/root/project/xfstests/results//generic/347.out.bad' to see the entire
diff)
This is expected because the dm-thin target currently lacks DAX support.
Just skip this test if we are using DAX.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
common/dmthin | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/common/dmthin b/common/dmthin
index baab6284..da0ad284 100644
--- a/common/dmthin
+++ b/common/dmthin
@@ -35,6 +35,11 @@ DMTHIN_POOL_DEV="/dev/mapper/$DMTHIN_POOL_NAME"
DMTHIN_VOL_NAME="thin-vol"
DMTHIN_VOL_DEV="/dev/mapper/$DMTHIN_VOL_NAME"
+echo $MOUNT_OPTIONS | grep -q dax
+if [ $? -eq 0 ]; then
+ _notrun "Cannot run tests with DAX on dmthin devices"
+fi
+
_dmthin_cleanup()
{
$UMOUNT_PROG $SCRATCH_MNT > /dev/null 2>&1
--
2.14.3
prev parent reply other threads:[~2018-01-18 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 23:23 [fstests PATCH 1/2] shared/272: don't use data journaling with DAX Ross Zwisler
2018-01-17 23:23 ` [fstests PATCH 2/2] generic/347: dm-thin lacks DAX support Ross Zwisler
2018-01-18 4:23 ` Eryu Guan
2018-01-18 16:06 ` Ross Zwisler
2018-01-18 16:07 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118160737.24708-1-ross.zwisler@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox