From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
overlayfs <linux-unionfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] overlay: test encode/decode overlay file handles
Date: Tue, 30 Jan 2018 12:54:14 +0800 [thread overview]
Message-ID: <20180130045414.GA18267@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAOQ4uxiRg9ZddvnzW-X8VMqpGOWva42qZmmBzdXUqoy-n34NRg@mail.gmail.com>
On Mon, Jan 29, 2018 at 07:23:49PM +0200, Amir Goldstein wrote:
> On Mon, Jan 29, 2018 at 4:39 PM, Eryu Guan <eguan@redhat.com> wrote:
> > On Sun, Jan 28, 2018 at 11:22:33AM +0200, Amir Goldstein wrote:
> >> - Check encode/write/decode/read content of lower/upper file handles
> >> - Check encode/decode/write/read content of lower/upper file handles
> >> - Check decode/read of unlinked lower/upper files and directories
> >> - Check decode/read of lower file handles after copy up, link and unlink
> >>
> >> This test requires and enables overlayfs NFS export support.
> >> NFS export support depends on and enables overlayfs index feature.
> >>
> >> This test covers only encode/decode of file handles for overlayfs
> >> configuration of all layers on the same base fs.
> >>
> >> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> >
> > Looks good to me overall, just two minor issues in comments.
> >
>
> OK. I fixed those comment in both test variants.
> Let me know if there is anything else, otherwise, I'll re-post
> with fixed to comment on patch 1.
Everything else looks fine to me. Sorry, I should have sent out an
explicit ack..
Thanks,
Eryu
next prev parent reply other threads:[~2018-01-30 4:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 9:22 [PATCH v3 0/5] Overlayfs exportfs tests Amir Goldstein
2018-01-28 9:22 ` [PATCH v3 1/5] fstests: implement require of multiple overlayfs features Amir Goldstein
2018-01-29 14:33 ` Eryu Guan
2018-01-29 17:06 ` Amir Goldstein
2018-01-30 4:52 ` Eryu Guan
2018-01-28 9:22 ` [PATCH v3 2/5] overlay: test encode/decode overlay file handles Amir Goldstein
2018-01-29 14:39 ` Eryu Guan
2018-01-29 17:23 ` Amir Goldstein
2018-01-30 4:54 ` Eryu Guan [this message]
2018-01-28 9:22 ` [PATCH v3 3/5] overlay: test encode/decode of non-samefs " Amir Goldstein
2018-01-28 9:22 ` [PATCH v3 4/5] overlay: test encode/decode overlay file handles with renames Amir Goldstein
2018-01-28 9:22 ` [PATCH v3 5/5] overlay: test encode/decode of non-samefs " Amir Goldstein
2018-01-28 10:59 ` [PATCH v3 0/5] Overlayfs exportfs tests Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130045414.GA18267@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox