From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Rostislav Skudnov <rostislav@tuxera.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] generic/{274,315}: Require falloc -k support
Date: Tue, 30 Jan 2018 08:14:37 -0800 [thread overview]
Message-ID: <20180130161437.GA4844@magnolia> (raw)
In-Reply-To: <1517320499-14714-3-git-send-email-rostislav@tuxera.com>
On Tue, Jan 30, 2018 at 01:54:59PM +0000, Rostislav Skudnov wrote:
> These test cases require filesystem support for FALLOC_FL_KEEP_SIZE
> flag in fallocate().
>
> Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/generic/274 | 2 +-
> tests/generic/315 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/generic/274 b/tests/generic/274
> index 7d09386..a3f8c75 100755
> --- a/tests/generic/274
> +++ b/tests/generic/274
> @@ -48,7 +48,7 @@ _cleanup()
> _supported_fs generic
> _supported_os Linux
> _require_scratch
> -_require_xfs_io_command "falloc"
> +_require_xfs_io_command "falloc" "-k"
>
> echo "------------------------------"
> echo "preallocation test"
> diff --git a/tests/generic/315 b/tests/generic/315
> index 4433b6c..954f8a9 100755
> --- a/tests/generic/315
> +++ b/tests/generic/315
> @@ -49,7 +49,7 @@ _cleanup()
> _supported_fs generic
> _supported_os Linux
> _require_test
> -_require_xfs_io_command "falloc"
> +_require_xfs_io_command "falloc" "-k"
>
> rm -f $seqres.full
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-01-30 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 13:54 [PATCH 0/2] Fix some _require_* checks for filesystem features Rostislav Skudnov
2018-01-30 13:54 ` [PATCH 1/2] generic/307: Require ACL support Rostislav Skudnov
2018-01-30 16:16 ` Darrick J. Wong
2018-02-03 5:06 ` Eryu Guan
2018-01-30 13:54 ` [PATCH 2/2] generic/{274,315}: Require falloc -k support Rostislav Skudnov
2018-01-30 16:14 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130161437.GA4844@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=rostislav@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox